Add external texture tests #1574
Open
+303
−644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bghgary
force-pushed
the
external-texture-tests
branch
from
15f6f78 to
50c538f
Compare
Fix broken move semantics in ExternalTexture Pass command line arguments to google test
There was a problem hiding this comment.
Pull request overview
This PR adds external texture tests to the BabylonNative codebase, introducing platform-specific test utilities for creating and destroying textures across Metal, D3D11, D3D12, and OpenGL backends.
Key changes include:
- Added comprehensive external texture tests with platform-specific texture creation utilities
- Fixed lambda capture semantics by adding
mutablekeyword wherestd::moveis used in lambda bodies - Refactored test infrastructure to support command-line arguments and consolidated test entry points
- Removed Android build artifacts and updated bgfx debug annotation configuration
Reviewed changes
Copilot reviewed 38 out of 40 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Apps/UnitTests/Source/Tests.ExternalTexture.cpp | New test file for external texture construction and async operations |
| Apps/UnitTests/Source/Utils*.cpp | Platform-specific texture creation/destruction utilities for D3D11, D3D12, Metal, and OpenGL |
| Apps/UnitTests/Source/App*.cpp | Refactored main entry points to accept argc/argv parameters |
| Apps/UnitTests/CMakeLists.txt | Updated to include external texture tests and platform-specific utilities |
| Plugins/ExternalTexture/Source/ExternalTexture_Shared.h | Fixed lambda captures by adding mutable keyword for move operations |
| Core/Graphics/Source/DeviceImpl_Metal.cpp | Refactored Metal device type usage to use proper Objective-C id syntax |
| Dependencies/CMakeLists.txt | Moved BGFX_CONFIG_DEBUG_ANNOTATION setting to compile definitions to fix D3D12 access violation |
| CMakeLists.txt | Updated JsRuntimeHost dependency git tag |
| Android/* | Removed entire Android build infrastructure |
Files not reviewed (1)
- Apps/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
Apps/UnitTests/Source/App_X11.cpp:19
- Extra closing parenthesis in the function signature. The function should be declared as
int main(int argc, char* argv[])without the extra closing parenthesis.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bghgary
commented
Nov 22, 2025
Contributor
Author
There was a problem hiding this comment.
Need to update Install/Test again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.